-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agora): migrate Footer component and utils (AG-1548) #2858
Merged
tschaffter
merged 6 commits into
Sage-Bionetworks:main
from
sagely1:agora/migration-footer
Sep 26, 2024
Merged
feat(agora): migrate Footer component and utils (AG-1548) #2858
tschaffter
merged 6 commits into
Sage-Bionetworks:main
from
sagely1:agora/migration-footer
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagely1
changed the title
Agora/migration footer
feat(agora): migrate Footer component and utils
Sep 26, 2024
sagely1
changed the title
feat(agora): migrate Footer component and utils
feat(agora): migrate Footer component and utils (AG-1548)
Sep 26, 2024
sagely1
commented
Sep 26, 2024
sagely1
commented
Sep 26, 2024
tschaffter
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few comments. In addition, the first comment of this PR has two sections "Changelog" that should be consolidated into one section that uses bullet points.
tschaffter
reviewed
Sep 26, 2024
tschaffter
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration of Footer component
Changelog
Related Issue
https://sagebionetworks.jira.com/browse/AG-1548
Testing
nx test agora-home
Expected output
Navigate to:
http://localhost:4200